Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Goerli Network (Deprecated) #37369

Closed
StephenHeaps opened this issue Apr 5, 2024 · 3 comments · Fixed by brave/brave-core#24438
Closed

Remove Goerli Network (Deprecated) #37369

StephenHeaps opened this issue Apr 5, 2024 · 3 comments · Fixed by brave/brave-core#24438
Assignees
@onyb
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release

Comments

@StephenHeaps
Copy link

Description

Goerli network was deprecated as of April 1st, 2024:
https://www.alchemy.com/blog/goerli-faucet-deprecation

We should remove from pre-loaded networks list
@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/core labels Apr 5, 2024
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 26, 2024
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Apr 26, 2024
@StephenHeaps StephenHeaps mentioned this issue Jun 12, 2024
Merged
24 tasks
@onyb onyb mentioned this issue Jul 1, 2024
Merged
24 tasks
@brave-builds brave-builds mentioned this issue Jul 24, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Jul 24, 2024
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 24, 2024
@onyb onyb self-assigned this Jul 26, 2024
@kjozwiak
Copy link
Member

The above requires 1.69.130 or higher for 1.69.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Aug 5, 2024

Verified as part of #34920 (comment)

@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.69.147

  • Verified steps from brave/brave-core#24438
  • Verified setting up Goerli as default on older version and upgrading to 1.69.147 removes Goerli from Portfolio and sets Sepolia as default
34920.mp4

@LaurenWags LaurenWags mentioned this issue Aug 20, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): remove Goerli network brave/brave-core
6 participants
@jamesmudgett @kjozwiak @onyb @StephenHeaps @srirambv @brave-builds