Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #33275] Debouncing feature is not working for Base64 and Regex (multi) test cases #37026

Closed
hffvld opened this issue Mar 22, 2024 · 2 comments
Assignees
Labels

Comments

@hffvld
Copy link
Contributor

hffvld commented Mar 22, 2024

Description:

Follow-up to #33275

Steps to Reproduce

  1. Launch Brave
  2. Go to https://dev-pages.brave.software/navigation-tracking/debouncing.html
  3. Run through all 4 test cases > Observe, Base64 and Regex (multi) tests fail

Actual result:

The debouncing feature is not working for the Base64 and Regex (multi) test cases with Brave's default settings.

Default Base64 Regex Regex (multi)
1 2 3 4
1 2 3 4

Expected result:

When running any of the 4 test cases, dev-pages.brave.software referrer must be seen with Debouncing enabled.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.64 (109)
BraveCore: 1.64.109 (123.0.6312.58)
  • Can you reproduce this issue with the most recent build from TestFlight? YES
  • Can you reproduce this issue with the previous version of the current build from TestFlight? YES
  • Can you reproduce this issue with the current build from AppStore? YES

Device details:

iPhone 14 / iOS 17.4

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

cc @cuba

@hffvld hffvld added bug QA/Yes OS/iOS Fixes related to iOS browser functionality privacy/debounce URL debouncer labels Mar 22, 2024
@cuba
Copy link

cuba commented Apr 3, 2024

Fixed in the followng debounce refactor which uses the brave-core components:
brave/brave-core#22039

@cuba cuba closed this as completed Apr 3, 2024
@cuba cuba added this to the 1.66.x - Nightly milestone Apr 3, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 26, 2024

Verified on iPhone 12 running iOS 17.3.1 using version 1.66.90

  • Ensured that all 4 cases are showing https://dev-pages.brave.software for Observed Referrer
  • Ensured that "NoSuchKey" page is shown when disabling Auto-Redirect Tracking URLs in all cases.
Enabled Disabled
IMG_6006 IMG_6008

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants