Enable Brave Browser to be an AutoFill Provider

[kylehickinson]

Add the ability for Brave to be an password manager in a sense, where as the users stored passwords will then be accessible from the iOS keyboard in WKWebView

This involves adding a new target to the project AutoFill Credential Provider.

More information about the APIs can be found by watching the WWDC 2018 721 - Implementing AutoFill Credential Provider Extensions or reading the AuthenticationServices doc

• Add an AutoFill Credential Provider
• Use Chromium implementation for handling password <> AuthenticationServices sync
• Potentially have new UI for the AuthenticationServices API

Potential caveats to take into account:

• The user has to explicitly enable it in Settings > Passwords & Accounts > AutoFill Passwords
• The user can only have 2 (+ iCloud?) AutoFill providers enabled
• The user has to do this process manually via the keyboard unlike in 1.6 where the username/password were auto-filled upon loading the page.

Screenshots of AutoFill Providers (1Password in this case):

Enabling AutoFill Providers	Single AutoFill	Single Auto-Fill 2

Multiple Logins (Tapping the 🔑)	Tapping "1Password…" UI

[Jacalz]

This would be absolutely awesome, plus one from me 👌

[anthonypkeane]

@kylehickinson - we should implement this natively as Apple intended for iOS12.

When estimating, if it will be >13 story points let me know and we can discuss.

[kylehickinson]

@anthonypkeane It may be more than 13 story points but we'll need to get some questions answered before we can implement it. It's likely that This ticket becomes an Epic and we make smaller tickets for each part.

Some product questions:

1. Are we going to let users manage their logins?

   Currently in 1.6 we do not have any UI to show a list of the users logins. To make Brave an AutoFill provider, we will need UI to show if the user selects Brave (see Multiple Logins (Tapping the 🔑) above) where they can search logins.

2. Will they be able to save more than one login for a specific site?

   Currently in 1.6 we do not allow saving of multiple logins for 1 domain. When you save a login with new credentials it just overwrites the previous credentials for that domain.

3. Are we going to force/couple browser lock with password fill?

   A good way to explain this is 1Password. If you select something from the quick bar, iOS will present 1Password's unlock UI if you have not unlocked 1Password since a reboot, past a certain time limit, etc. Otherwise iOS will simply show a face-ID unlock to fill the password.

   However, if you click the 🔑 icon and select password, it will then bring up 1Password's own UI for authentication (which may be your master password or Face ID/Touch ID)

   Maybe it'd be better to loop in someone from security for this question.

4. Are we going to have user instruction anywhere on how to set this up?

   As I mentioned in the original post "The user has to explicitly enable it in Settings > Passwords & Accounts > AutoFill Passwords". Since there's no special auto-fill that can be enabled for the AutoFill Provider itself (unlike Content Blockers which can be attached directly to the WKWebView)

   If we are going to have user instruction, we'll need copy, a flow and UI to go along with it.

[pk27734]

Will migrate from Firefox to Brave once this is implemented!

[aaronsantamaria]

+1
https://community.brave.com/t/autofill-passwords-integration-in-ios-missing/182859/2

[Mennaruuk]

This holds me back from using Brave on iOS.

[boris-bc]

lol, blocked since 2018

[onyxcode]

Guess this is just never happening

[Saoiray]

@anthonypkeane this has been dead in the water for quite some time. Any intention on getting Brave to work with iOS to be able to autofill for passwords? It's still unable to be chosen in iOS settings and therefore passwords from within Brave can't be used to autofill on sites. Sure, passwords get saved into Brave but then can't be accessed except we go the long way around of going into Brave's settings -> logins and passwords -> then copy/paste info.

[iccub]

We have it planned for this quarter

[Saoiray]

We have it planned for this quarter

Awesome, thanks. It's something definitely have been wanting/needing for a while. Hopefully no roadblocks and can get it out with no issue before long.

[smartin-qb]

We have it planned for this quarter

Any updates? eagerly anticipating this feature.

[kylehickinson]

No definite release date yet, sorry, but it's almost there 🙂

[davidcollini]

Congrats on the implementation!

[Saoiray]

@kylehickinson glad to see it looks like might be coming, but is it really going to be waiting until 1.66 or we have likelihood of uplifting to sooner release? Asking as we're currently on 1.62.2 for iOS. Trying to figure out how long of a wait for everyone.

[kylehickinson]

@Saoiray iOS releases are a bit behind, 1.63 will come next week followed very quickly by 1.64. We may however uplift this into 1.65 (mid-April) to get it out a bit quicker.

[Saoiray]

@Saoiray iOS releases are a bit behind, 1.63 will come next week followed very quickly by 1.64. We may however uplift this into 1.65 (mid-April) to get it out a bit quicker.

kk. Thanks for the info. I'll be looking forward to it.

[iccub]

This will land in public beta soon and as far as I remember we are going to allow default browser setting for public beta app soon as well

[Uni-verse]

Verified on iPhone 12 running iOS 17.3.1 using version 1.66.104

• Verified Test Plan in [iOS] Add AutoFill Credential Provider Extension brave-core#22553 (comment) and additionally verified the below test cases:
• Ensured Brave is shown as an autofill provider in Password Options and can be enabled for new and existing users.
• Ensured existing saved passwords in Brave are not changed when upgrading.
• Ensured Brave autofill data is shown in saved passwords.
• Ensured that autofill data is populated when selecting saved password from Brave.

Autofill settings	Confirmation	Saving password	Saved Password	Using Saved Password

• Ensured tapping the key icon will display multiple saved password if available.
• Ensured password field can be populated by opening the saved password details and tapping on Use in the top right.
• Ensured copied password can be pasted when opening password manager and selecting copy from the context menu.
• Ensured revealing password works when tapping on the eye in Brave Passwords.
• Ensured other (non-Brave) autofill provider can be used for autofill along with Brave.

Example	Example	Example	Example	Example

• Ensured that Brave autofill is enabled on other apps on the device.

Example	Example	Example