Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resize window causes time to overlap on stats #341

Closed
srirambv opened this issue Jun 14, 2018 · 1 comment · Fixed by brave/brave-core#1091
Closed

Resize window causes time to overlap on stats #341

srirambv opened this issue Jun 14, 2018 · 1 comment · Fixed by brave/brave-core#1091
Assignees
@rossmoody
Labels
design A design change, especially one which needs input from the design team feature/new-tab feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.60.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Resize window causes time to overlap on stats

Steps to Reproduce

  1. Open a new tab ensure you have stats value shown in new tab
  2. Resize the window by dragging the right side of the window to make it min width possible
  3. Time shown on new tab overlaps the stats

Actual result:

Comparison of browser-laptop vs brave-core
image

Expected result:

Nothing should overlap in new tab

Reproduces how often:

100%

Brave version (about:brave info)

332140d

cc: @bradleyrichter
@srirambv srirambv added feature/new-tab design A design change, especially one which needs input from the design team labels Jun 14, 2018
@srirambv srirambv added this to the Backlog milestone Jun 14, 2018
@srirambv srirambv added the feature/user-interface All UI related label Jun 14, 2018
@cezaraugusto cezaraugusto mentioned this issue Jun 15, 2018
Closed
@rossmoody rossmoody mentioned this issue Dec 13, 2018
Merged
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Dec 20, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Feb 5, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.60.19 Chromium: 72.0.3626.81 (Official Build) beta(64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X
  • Verified resizing the new tab page did not overlap time and stats
    screen shot 2019-02-05 at 1 01 48 pm

Verification passed on

Brave 0.60.25 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10
  • Verified STR mentioned in the description, resizing the new tab page did not overlap time and stats

image

Verification passed on

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

image

@kjozwiak kjozwiak mentioned this issue Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
design A design change, especially one which needs input from the design team feature/new-tab feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

NTP Refinement brave/brave-core
7 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya