Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with EIP-1559 fee estimation on zksync (part 2) #31959

Closed
onyb opened this issue Jul 28, 2023 · 2 comments · Fixed by brave/brave-core#19481
Closed

Issues with EIP-1559 fee estimation on zksync (part 2) #31959

onyb opened this issue Jul 28, 2023 · 2 comments · Fixed by brave/brave-core#19481
Assignees
@onyb
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release #7

Comments

@onyb
Copy link
Member

onyb commented Jul 28, 2023 •
edited
Loading

zksync strikes back!

Community https://community.brave.com/t/zksync-era-failed-transactions-due-to-eip-1559-error

It appears that zksync Era has finally implemented the eth_feeHistory RPC, absence of which previously broke EIP-1559 fee estimation (#30473), but the response breaks our parser. As a result, users are unable to transact on zksync anymore. See an example from syncswap below.

Screenshot 2023-07-29 at 01 10 40

On the bright side, getting fee estimates is now 2x faster on zksync.
@onyb onyb added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop feature/web3/wallet/core labels Jul 28, 2023
@onyb onyb self-assigned this Jul 28, 2023
@onyb onyb added this to Web3 Jul 28, 2023
@onyb onyb changed the title Issues with EIP-1559 fee estimation on zksync Issues with EIP-1559 fee estimation on zksync (part 2) Jul 28, 2023
@onyb onyb moved this to In Review in Web3 Jul 28, 2023
@onyb onyb mentioned this issue Jul 29, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 31, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 31, 2023
This was referenced Jul 31, 2023
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Aug 1, 2023

The above requires 1.56.18 or higher for 1.56.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Aug 1, 2023

Verification passed on

Brave 1.56.18 Chromium: 115.0.5790.138 (Official Build) (64-bit)
Revision 0567db0e7dcdfee5c109c167119ac2a92b9b3e1a-refs/branch-heads/5790_85@{#9}
OS Windows 11 Version 22H2 (Build 22621.1992)
  • Verified steps from brave/brave-core#19481
  • Verified panel shows correct fee estimates for zksync transactions
31959.mp4

@LaurenWags LaurenWags mentioned this issue Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release #7
Development

Successfully merging a pull request may close this issue.

fix(wallet): handle nullable reward in eth_feeHistory brave/brave-core
4 participants
@kjozwiak @onyb @srirambv @brave-builds