Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change table remove icons from X to trash in Rewards #3178

Closed
rossmoody opened this issue Jan 31, 2019 · 1 comment
Closed

Change table remove icons from X to trash in Rewards #3178

rossmoody opened this issue Jan 31, 2019 · 1 comment
Assignees
@rossmoody
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.62.x - Release ...

Comments

@rossmoody
Copy link
Contributor

After discussion with @jenn-rhim and @NejcZdovc and @srirambv, we're gonna switch up the table row icons from a X to a trash can for continuity and to distance from the "close" feeling.
image
@rossmoody rossmoody added this to the 0.62.x - Nightly milestone Jan 31, 2019
@rossmoody rossmoody self-assigned this Jan 31, 2019
@rossmoody rossmoody mentioned this issue Jan 31, 2019
Merged
@rebron rebron modified the milestones: 0.62.x - Nightly, 1.x Backlog Feb 1, 2019
@rossmoody rossmoody mentioned this issue Feb 4, 2019
Merged
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.62.x - Nightly Feb 4, 2019
@btlechowski
Copy link

btlechowski commented Feb 28, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.62.8 Chromium: 73.0.3683.39 (Official Build) dev (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

image
image

Verification passed on

Brave 0.62.26 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
  • Verified the STR mentioned in the description
    image
    image

Verified passed with

Brave 0.62.28 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Screen Shot 2019-03-15 at 3 42 30 PM
Screen Shot 2019-03-15 at 3 42 36 PM

@kjozwiak kjozwiak mentioned this issue Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@rebron @NejcZdovc @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya