Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Always keep track of playing media #31271

Closed
btlechowski opened this issue Jun 23, 2023 · 3 comments
Closed

[ads] Always keep track of playing media #31271

btlechowski opened this issue Jun 23, 2023 · 3 comments

Comments

@btlechowski
Copy link

Currently, we keep track of playing media when ads are on, which creates problems
Since ShouldAlwaysRunBraveAdsService we can always keep track of playing media.

Steps to Reproduce

  1. Clean profile
  2. Enable rewards and ads
  3. Turn off ads
  4. Start playing a video on youtube
  5. Turn on ads
  6. Trigger a notification ad

Note: make media playing tracking per tab as it may happen that two or more videos are playing at the same time

Actual result:

ad is shown

Expected result:

ad is not shown because media is playing

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.54.74 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit)
Revision f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS Ubuntu 18.04 LTS

cc @tmancey @aseren

@tmancey
Copy link
Contributor

tmancey commented Oct 10, 2023

Blocked as discussing with @iambrianfung

@tmancey
Copy link
Contributor

tmancey commented Oct 24, 2023

@iambrianfung to discuss with stakeholders

@tmancey tmancey changed the title Always keep track of playing media [ads] Always keep track of playing media Oct 25, 2023
@tmancey
Copy link
Contributor

tmancey commented Oct 25, 2023

This is by-design as users would only be playing audio on the other tabs, and therefore, ads should still be shown.

@tmancey tmancey closed this as completed Oct 25, 2023
@tmancey tmancey self-assigned this Oct 25, 2023
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants