Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The metrics Brave.Wallet.EthProvider.4 response is incorrect when both Brave wallet and MM wallets are created #31224

Closed
GeetaSarvadnya opened this issue Jun 22, 2023 · 2 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 22, 2023

Description

Found while testing brave/brave-core#18782
The metrics Brave.Wallet.EthProvider.4 response is incorrect when both Brave wallet and MM wallets are created

Steps to Reproduce

  1. Clean profile 1.55.2
  2. Install and create a MM wallet and create a Brave wallet
  3. Open any HTTPS site
  4. Open brave://local-state file and look for the metrics Brave.Wallet.EthProvider.4
  5. The metrics Brave.Wallet.EthProvider.4 response value is 2 Brave Wallet (wallet is setup, no installed extension) instead of 4 or 5 not sure but definately not 2 response

Actual result:

The metrics Brave.Wallet.EthProvider.4 response is incorrect when both Brave wallet and MM wallets are created

Expected result:

Response should be 4 or 5

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.55.2 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit)
Revision f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS Windows 10 Version 22H2 (Build 19045.3086)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @mattmcalister @DJAndries

@DJAndries
Copy link
Collaborator

Clean profile 1.52.2

You meant 1.55.x, right?

When the web3 menu setting is set to "Extensions (Brave Wallet fallback)", I get answer 5, which is expected.

@GeetaSarvadnya
Copy link
Author

@DJAndries Verified the issue again, now I am getting the correct response as 5 I am not sure why I was getting 2 yesterday. Closing the issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants