Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shield settings icon missing in brave://settings/content page #31162

Closed
GeetaSarvadnya opened this issue Jun 20, 2023 · 3 comments · Fixed by brave/brave-core#18975
Closed

Shield settings icon missing in brave://settings/content page #31162

GeetaSarvadnya opened this issue Jun 20, 2023 · 3 comments · Fixed by brave/brave-core#18975

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #30200
Shield settings icon missing in brave://settings/content page

Steps to Reproduce

Actual result:

image

Expected result:

image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.54.72 Chromium: 115.0.5790.32 (Official Build) nightly (64-bit)
Revision f9b78cf410ecd5b372310ef25a12ef456c77d90f-refs/branch-heads/5790@{#724}
OS Windows 10 Version 22H2 (Build 19045.3086)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @emerick @rebron

@emerick
Copy link
Contributor

emerick commented Jun 20, 2023

I think this might be related to #30189 rather than cr115, but please let me know. cc: @fallaciousreasoning @petemill

@GeetaSarvadnya
Copy link
Author

@emerick This issue is reproducible in nightly build with CR 114 so it's not related to CR 115 definately

@stephendonner
Copy link

Verified PASSED using

Brave 1.57.16 Chromium: 115.0.5790.98 (Official Build) beta (x86_64)
Revision d6c8a44fbe78ae6ee53d838307b4d17bec8de940
OS macOS Version 11.7.8 (Build 20G1351)

Steps:

  1. installed 1.57.16
  2. launched Brave
  3. opened brave://settings/content
  4. double-checked the icon beneath Shields status

Confirmed the icon appears in both Light and Dark themes

Light Dark
Screen Shot 2023-07-18 at 2 58 46 PM Screen Shot 2023-07-18 at 2 59 02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment