Tor window always starts with default shields setting

[simonhong]

Description

Tor window always starts with default shields settings when user has different shields settings in normal profile

Steps to Reproduce

1. Change any settings in default shields settings in normal window
2. Launch tor window
3. Check it is applied to tor window

Actual result:

Tor window always starts with default shields setting

Expected result:

Tor window starts with custom shields settings of normal window

Reproduces how often:

always

Brave version (brave://version info)

every version

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? No
• Is the issue reproducible on the latest version of Chrome? No

Additional Information

Currently, this is expected behavior because tor window uses different profile with other normal windows.

[user809256]

Is there any fix for this issue?

I kinda don't see point in Tor network when fingerprint and script shields are down by default. I need to enable all shields manually for every website because global settings don't exist for guest/tor user?

Please tell me if there is any workarounds currently for this issue. Thanks ^^

[yrliou]

This is fixed by brave/brave-core#3319.

[btlechowski]

Verification passed on

Brave	0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision	edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS	Ubuntu 18.04 LTS

Verified test plan from the description
Verified test plan from brave/brave-core#3319
Verified bookmarks and global settings are shared between normal and tor window. Extensions are not shared yet per #2307 (comment)
Verified that brave://settings page is redirected to normal window.

Verification passed on

Brave	0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from the description
• Verified test plan from Tor profile rework brave-core#3319
• Verified that open brave://settings in TOR window is redirected to normal window
• Verified bookmarks and global settings are shared between normal and tor window. Extensions are not shared yet per Refactor Tor implementation to retain consistent profile #2307 (comment)

Verified passed with

Brave	1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from the description
• Verified test plan from Tor profile rework brave-core#3319
• Verified that open brave://settings in TOR window is redirected to normal window
• Verified bookmarks and global settings are shared between normal and tor window. Extensions are not shared yet per Refactor Tor implementation to retain consistent profile #2307 (comment)