Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android 13] Restyle Chromium enable notifications dialog #25593

Closed
timchilds opened this issue Sep 23, 2022 · 3 comments · Fixed by brave/brave-core#15829
Closed

[Android 13] Restyle Chromium enable notifications dialog #25593

timchilds opened this issue Sep 23, 2022 · 3 comments · Fixed by brave/brave-core#15829

Comments

@timchilds
Copy link

Summary
CR106 introduced a new dialog to encourage users to enable notifications. This dialog was appearing during and interfering with our onboarding. As a quick fix we moved the dialog outside of the onboarding experience.

We now need to restyle the dialog to be more inline with our styling and call out Brave features that require notifications to function. e.g. rewards and privacy report.

image

@deeppandya
Copy link
Contributor

@Sam-Sibley can you attach figma spec here ?

@Sam-Sibley
Copy link

@deeppandya , Ryan has done the copy. This is good to go.
Screenshot 2022-10-13 at 11 18 45 am

Here is the link:
https://www.figma.com/file/sdVBBufbl2A11hAgPNfyqG/Android-13-Notifications?node-id=363%3A30672

@kjozwiak
Copy link
Member

kjozwiak commented Nov 30, 2022

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.46.130 Chromium: 108.0.5359.62 (Official Build) (32-bit)
--- | ---
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS | Android 13; Build/T1B3.221003.008

Went through the STR/Cases outlined via brave/brave-core#15829 (comment) and ensured that the new UI is working as per the following:

  • ensured that the Android 13 permission modal appears once the URL bar onboarding has completed
  • ensured that tapping on Continue displays the system permission screen without any issues
  • ensured that tapping on Not now closes the modal without loading the system permission modal
  • ensured that the screen/modal only appears once after the URL onboarding (ensuring it's not seen a second time)
Example Example
Screenshot_20221130-002943 Screenshot_20221130-002949

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.46.130 Chromium: 108.0.5359.62 (Official Build) (32-bit)
--- | ---
Revision | 041930a89a990cfab0315a2d9f20d6429a4a67cf-refs/branch-heads/5359@{#938}
OS | Android 13; Build/TP1A.220624.014

Went through the STR/Cases outlined via brave/brave-core#15829 (comment) and ensured that the new UI is working as per the following:

  • ensured that the Android 13 permission modal appears once the URL bar onboarding has completed
  • ensured that tapping on Continue displays the system permission screen without any issues
  • ensured that tapping on Not now closes the modal without loading the system permission modal
  • ensured that the screen/modal only appears once after the URL onboarding (ensuring it's not seen a second time)
Example Example
Screenshot_20221130_003756_Brave Screenshot_20221130_003802_Permission controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment