Persist "Advanced Controls" section in Shields v2 panel

[Miyayes]

Description

Some users have complained that the "Advanced Controls" section does not stay open, and that they prefer to always see Advanced Controls when opening the Shields panel. (In the past, this would be like the "Advanced View" in Shields v1.)

Currently:

The UI panel by default keeps advanced view section hidden unless you’ve expanded it before. Internally, it keeps a cache of the panel and while it’s in the cache, it remembers that it was previously expanded. If you’re coming back to it after a 1-2min the cache gets destroyed and you start the flow over i.e it creates a fresh panel UI instance again.

per @nullhook

Proposed solution

Persist the Advanced Controls section, and do not let it expire after 1-2 minutes.

[stephendonner]

Verified PASSED using

Brave	1.43.61 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
Revision	5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS	macOS Version 11.6.8 (Build 20G730)

Steps:

1. installed 1.43.61
2. launched Brave
3. visited huffpost.com and clicked on the Brave icon on the right the URL bar
4. clicked on the "Advanced controls" button and confirmed it expanded
5. opened a new browser window
6. loaded espn.com
7. clicked on the Brave icon; confirmed Shields' controls were expanded
8. waited 5min idle so the current panel instance destroys and open a new one
9. loaded nbcnews.com
10. clicked to confirm the panel was still expanded
11. restarted Brave
12. loaded cnn.com
13. confirmed Advanced controls are expanded by default
14. loaded brave.com
15. clicked on Advanced controls to collapse the widget
16. confirmed it was collapsed and persisted after restart

step 3-4	step 7	step 8-10	step 11-12	step 13-14	step 15

[MadhaviSeelam]

Verification PASSED using

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Steps:

1. installed 1.43.91
2. launched Brave
3. visited nytimes.com and clicked on the Brave icon on the right the URL bar
4. clicked on the "Advanced controls" button and confirmed it expanded
5. opened a new browser window
6. loaded espn.com
7. clicked on the Brave icon; confirmed Shields' controls were expanded
8. waited 5min idle so the current panel instance destroys and open a new one
9. opened a NTP and loaded bbc.com
10. clicked on the Brave icon; confirmed Shields' controls were expanded
11. opened a new private window
12. loaded nbcnews.com
13. clicked to confirm the panel was still expanded
14. restarted Brave
15. loaded cnn.com
16. confirmed Advanced controls are expanded by default
17. loaded brave.com
18. clicked on Advanced controls to collapse the widget
19. confirmed it was collapsed and persisted after restart

step 3-4	step 5-7	step 9-10	step 11-13