Twitch in-stream advertisements not being blocked

[UndercoverNL]

Description

When watching twitch.tv streams none of the ads playing in stream are blocked, both the pre-roll and mid-stream ads are just being played like on another browser.

Steps to Reproduce

Watch a stream on https://twitch.tv/, or swich to a few streams and at some of them a pre-roll ad will come-up

Actual result:

All kind of in-stream video ads being played

Expected result:

No (video) ads being played before or in streams

Reproduces how often:

Always an ad is being played by the streamer / twitch

Brave version (brave://version info)

1.37.116 Chromium: 100.0.4896.127 (Official Build) (64-bit)

Version/Channel Information:

It also happens in Brave Beta, so I guess it happens on all versions

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Idk what this is

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? no
• Does the issue resolve itself when disabling Brave Rewards? no
• Is the issue reproducible on the latest version of Chrome? yes

[ryanbr]

Related to this, #23014 no ETA just yet

[UndercoverNL]

I don't see why its related to 23014, it should be blocked by Brave it self, not by using a third party app.

Anyway, it is still an problem which should be an higher priority to me. A lot of people use twitch and Brave should filter those ads out too.

[Zerophase]

Trying aggresively blocking ads to see if it works.

[UndercoverNL]

@Zerophase what exactly do you mean with aggresively blocking ads?

[Zerophase]

The aggressively block ads and trackers option.

[ryanbr]

With the latest https://github.com/pixeltris/TwitchAdSolutions

• Shields enabled
  Testing the top twitch extensions with twitch adblocking in Brave.

Extension	Last updated	Breaks Brave?	Extension works?	Brave still blocks ads?	Comments
Twitch Lurker	Jul 2024	No	Yes	Yes	Extension works as expected
Twitch High Quality	Jul 2024	No	Yes	Yes	Extension works as expected
Alternate Player for Twitch.tv	Jun 2024	No	Yes	N/A	Extension takes over twitch
Unwanted Twitch	Apr 2024	No	Yes	Yes	Extension works
Previews (For TTV & YT	Nov 2024	No	Yes	Yes	Extension works
Better Twitch Adblock	Jan 2023	No	No	Yes	No ads seen
Stream Cleaner	May 2024	No	No	No	Ads not blocked by either Brave or Stream Cleaner
Adblock for Twitch	Nov 2022	No	No	No	Ads not blocked by either Brave or Adblock for Twitch
TTV LOL PRO	Sep 2024	No	No	No	Ads not blocked by either Brave or TTV LOL Pro

• Shields enabled: Combo of twitch extensions
  Combining more than one extension) More of an edgecase/extreme test

Extension	Breaks Brave?	Extension works?	Brave still blocks ads?	Comments
TTV LOL PRO+ Stream Cleaner	No	Not the adblocking	No	Ad seen
TTV LOL PRO+ Stream Cleaner+Better Twitch Adblock	No	Not the adblocking	No	Ad seen
TTV LOL PRO+ Stream Cleaner+Better Twitch Adblock+Adblock for Twitch	No	Not the adblocking	No	Ad seen

• Shields disabled
  Do these extensions by itself, block twitch ads still (tested in mid-Nov 2024)

Extension	Breaks Brave?	Does it block ads?	Comments
Stream Cleaner	No	No	Ads seen in Stream Cleaner 1.17.0
TTV LOL PRO	No	Yes	Partially blocked, commercial overlay, also slow and often shows black screen with loading circle.
Better Twitch Adblock	No	No	Ads seen in Better Twitch Adblock 1.0.2

Looks like some (all) of these extension aren't blocking Twitch ads. Using Shields by itself, we're blocking the current embedded twitch ads.

[ryanbr]

Update 25th Jan/2025 (Not including brave/adblock-resources#232)

TLDR; No bad interactions with Brave Twitch adblocking and these popular extensions, no black screens. Video playback was fine.

Brave twitch blocks ads?	Extension
No	TTV Lol Pro 2.3.10 adblocker working (2)
Yes	Stream cleaner 1.17.0 (not working?)
Yes	Better Twitch AdBlock (3.0.3)
Yes	Adblock for Twitch (1.0.2)
Yes	FrankerFaceZ (4.76.3.0) + 7TV (3.0.9)
No	(blocking ads still) ALL Extensions enabled. (1)
Yes	ALL Extensions enabled except TTV Lol pro (1) (2) .

1. Unsure if running all extensions would cause any issues, bad interactions expected. But not Brave related.
2. TTV Lol Pro has its own adblocker, which overrides Brave. Still block ads.

[ryanbr]

As of (2 Feb) + Experimental: (Version: 1.0.45)

• Android Tablet:

• IOS/iPAD

[Zerophase]

I have not been seeing them since. But, it might also be my firewall blocking ads through Sensei, Unbound, and me connecting to Twitch from Hong Kong.