Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Tipping Option on YouTube (or Twitch) #2089

Closed
jonathansampson opened this issue Nov 10, 2018 · 1 comment · Fixed by brave/brave-core#888
Closed

No Tipping Option on YouTube (or Twitch) #2089

jonathansampson opened this issue Nov 10, 2018 · 1 comment · Fixed by brave/brave-core#888

Comments

@jonathansampson
Copy link
Contributor

jonathansampson commented Nov 10, 2018

Test Plan

brave/brave-core#888

Description

No tipping button is presented while on YouTube and/or Twitch.

Steps to Reproduce

From a fresh profile…

  1. Enable Brave Rewards, claim grant.
  2. Open https://www.youtube.com/watch?v=Wq-YZJ2CR0I in a tab.
  3. Open https://twitch.tv/ninja in a tab.
  4. Expand Rewards Panel for both tabs.

Actual result:

Some panels don't offer a tipping option

Expected result:

Tipping should be offered on both YouTube and Twitch

Reproduces how often:

Always

Brave version (brave://version info)

0.57.3

Additional Information

image

Potentially related to #1814

@LaurenWags
Copy link
Member

LaurenWags commented Feb 12, 2019

Verified passed with

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verified passed with

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Verification passed on

Brave 0.60.27 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants