Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace crlsets with redirector #20609

Closed
kjozwiak opened this issue Jan 21, 2022 · 2 comments · Fixed by brave/brave-core#11917
Closed

Replace crlsets with redirector #20609

kjozwiak opened this issue Jan 21, 2022 · 2 comments · Fixed by brave/brave-core#11917

Comments

@kjozwiak
Copy link
Member

Test Plan

Information/Context

@kjozwiak
Copy link
Member Author

@brave/legacy_qa please ping me when you're about to run through the above. This requires some configuration from @linhkikuchi via server side before we can run through the STR/Cases.

@stephendonner
Copy link

stephendonner commented Feb 4, 2022

Verified PASSED using

Brave 1.36.84 Chromium: 98.0.4758.87 (Official Build) dev (x86_64)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. set up Charles Proxy
  2. installed Brave
  3. ran Charles Proxy
  4. launched Brave
  5. loaded brave://components

Confirmed:

  • spellcheck dictionary request is handled over in Spellcheck dictionaries downloaded via crlsets.brave.com #16380
  • requests for components were proxied through redirector.brave.com and all return 200 OK (e.g. https://redirector.brave.com/edgedl/release2/chrome_component/acswg5tbkr2ithrql6kjeh6vvwrq_2022.1.24.1201/ggkkehgbnfjpeggfpleeakpidbkibbmn_2022.1.24.1201_all_oa3ppuxckzsaqpp445iqxhz4e4.crx3)
  • requests via componentupdater.brave.com were handled and returned 200 OK (e.g. https://componentupdater.brave.com/service/update2/json
  • within an 8-minute window, brave://components updated with a successful check for CRLSet, and displayed Up-to-date status
  • also confirmed requests had a braveservicekey header w/key value (not pictured)
example example example
Screenshot 2022-02-04 at 06 47 44 Screenshot 2022-02-04 at 06 53 37 Screenshot 2022-02-04 at 06 45 36

Verified PASSED using

Brave 1.36.88 Chromium: 98.0.4758.87 (Official Build) dev (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Windows 10 Version 21H2 (Build 19044.1466)

Steps:

  1. set up Charles Proxy
  2. installed Brave
  3. ran Charles Proxy
  4. launched Brave
  5. loaded brave://components

Confirmed:

  • spellcheck dictionary request is handled over in Spellcheck dictionaries downloaded via crlsets.brave.com #16380
  • requests for components were proxied through redirector.brave.com and all return 200 OK (e.g. https://redirector.brave.com/edgedl/release2/chrome_component/acswg5tbkr2ithrql6kjeh6vvwrq_2022.1.24.1201/ggkkehgbnfjpeggfpleeakpidbkibbmn_2022.1.24.1201_all_oa3ppuxckzsaqpp445iqxhz4e4.crx3)
  • requests via componentupdater.brave.com were handled and returned 200 OK (e.g. https://componentupdater.brave.com/service/update2/json
  • within an 8-minute window, brave://components updated with a successful check for CRLSet, and displayed Up-to-date status
  • also confirmed requests had a braveservicekey header w/key value (not pictured)
example example example
20609-1 20609-2 20609-3

Verification passed on

Brave 1.36.94 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Ubuntu 18.04 LTS

Confirmed:

  • spellcheck dictionary request is handled over in Spellcheck dictionaries downloaded via crlsets.brave.com #16380
  • requests for components were proxied through redirector.brave.com and all return 200 OK (e.g. https://redirector.brave.com/edgedl/release2/chrome_component/acswg5tbkr2ithrql6kjeh6vvwrq_2022.1.24.1201/ggkkehgbnfjpeggfpleeakpidbkibbmn_2022.1.24.1201_all_oa3ppuxckzsaqpp445iqxhz4e4.crx3)
  • requests via componentupdater.brave.com were handled and returned 200 OK (e.g. https://componentupdater.brave.com/service/update2/json
  • within an 8-minute window, brave://components updated with a successful check for CRLSet, and displayed Up-to-date status
  • also confirmed requests had a braveservicekey header w/key value (not pictured)
example example example
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants