Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The uplift script/pipeline should not fail if the PR being uplifted is not merged yet #20378

Closed
wknapik opened this issue Jan 7, 2022 · 0 comments · Fixed by brave/brave-core#14202
Closed

The uplift script/pipeline should not fail if the PR being uplifted is not merged yet #20378

wknapik opened this issue Jan 7, 2022 · 0 comments · Fixed by brave/brave-core#14202
Assignees
@kim0
Labels
ci-concern dev-experience OS/Linux QA/No release-notes/exclude
Milestone
1.43.x - Release

Comments

@wknapik
Copy link
Contributor

wknapik commented Jan 7, 2022 

[ERROR] Pull request XXXXX has not been merged yet. Only merged requests can be uplifted.

Testing happens in each PR (for each channel) separately anyway, so why wait?

It currently takes several hours for CI to pass for a PR. We could be testing uplifts simultaneously with the original PR and cut several hours out of the process of getting a change to multiple channels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kim0 kim0

Labels
ci-concern dev-experience OS/Linux QA/No release-notes/exclude
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Allow uplifting unmerged prs brave/brave-core
4 participants
@kim0 @mihaiplesa @wknapik @brave-builds