Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that all Shields text/background have sufficient contrast #1956

Closed
tildelowengrimm opened this issue Nov 1, 2018 · 2 comments
Closed

Ensure that all Shields text/background have sufficient contrast #1956

tildelowengrimm opened this issue Nov 1, 2018 · 2 comments
Labels
accessibility closed/invalid feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@tildelowengrimm
Copy link
Contributor

Can check contrast performance with this tool. Ideally, we should be going for AAA, but AA should be okay.
@tildelowengrimm tildelowengrimm added feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team accessibility feature/shields/panel Front-end design and functionality of the Shields panel. labels Nov 1, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@tildelowengrimm tildelowengrimm added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Nov 6, 2018
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 6, 2018
@tildelowengrimm tildelowengrimm mentioned this issue Nov 6, 2018
Closed
@karenkliu
Copy link

karenkliu commented Nov 16, 2018 •
edited
Loading

@tomlowenthal @cezaraugusto
Shields color update:
slice
Abstract link (for CSS): https://share.goabstract.com/4a733bfa-bf8e-45f2-89ac-e1b4c3908e3e

@tildelowengrimm tildelowengrimm removed design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Nov 28, 2018
@karenkliu
Copy link

Closing this issue because comprehensive design specs and other issues are covered by #2565

@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Dec 20, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility closed/invalid feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tildelowengrimm @bbondy @karenkliu