Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP-1559 support for Ledger hardware wallets #18182

Closed
srirambv opened this issue Sep 17, 2021 · 2 comments · Fixed by brave/ethereum-remote-client#272
Closed

Add EIP-1559 support for Ledger hardware wallets #18182

srirambv opened this issue Sep 17, 2021 · 2 comments · Fixed by brave/ethereum-remote-client#272
Labels
feature/ethereum-remote-client OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Milestone
Ethereum Remote C...

Comments

@srirambv
Copy link
Contributor

Add EIP-1559 support for Ledger hardware wallets
@srirambv srirambv mentioned this issue Sep 17, 2021
Merged
3 tasks
@srirambv
Copy link
Contributor Author

Fixed by brave/ethereum-remote-client#272

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.29.81 Chromium: 93.0.4577.82 (Official Build) (x86_64)
Revision e3a25d9b9e2d0b728e045ec87c0aa4942aa46e4e-refs/branch-heads/4577@{#1237}
OS macOS Version 11.5.2 (Build 20G95)
Component 1.0.40 Dev
Verified test plan from brave/ethereum-remote-client#272
  • Verified able to connect ledger to wallet without any issues
    image image
  • Verified able to perform a simple send transaction on mainnet using EIP-1559 gas pricing. [TxHash]
    image image image
  • Verified able to perform a ERC-20 token transfer on Ethereum mainnet using EIP-1559 gas pricing [TxHash]
    image image
  • Verified able to perform swap MATIC-DAI on 1inch Polygon using legacy gas pricing[TxHash]
    image image image image
  • Verified able to perform a simple send transaction on Polygon mainnet using legacy gas pricing[TxHash]
    image image image
  • Verified able to create an account on Instadapp Polygon (mainnet) using legacy gas pricing. [TxHash]
    image image
  • Verified able to create an account on Instadapp Ethereum (mainnet) using EIP-1559 gas pricing [TxHash]
    image image
  • Verified able to swap assets on Uniswap using legacy gas pricing [TxHash]
    image image image

@onyb onyb mentioned this issue Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/ethereum-remote-client OS/Desktop QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
Ethereum Remote Client v1.0.35
Development

Successfully merging a pull request may close this issue.

feat(eip1559): enable EIP-1559 transaction signing on Ledger HW brave/ethereum-remote-client
1 participant
@srirambv