Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave logo is cut off on dowjones prom subscription page #1809

Closed
btlechowski opened this issue Oct 23, 2018 · 4 comments
Closed

Brave logo is cut off on dowjones prom subscription page #1809

btlechowski opened this issue Oct 23, 2018 · 4 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. (Important) Uninstall Brave Browser with User Data to have a Clean install
    image
  2. (On Windows )Download stub/mini installer and rename it to BraveBrowserSetup-dowjones-barrons.exe
  3. Run the stub/mini installer
  4. After Brave has started wait for https://brave.com/dowjones-barrons page to be shown (can take up to 60 seconds)

Actual result:

Brave logo is cut off on the top of the page
image

Expected result:

Brave logo is not cut off

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows 7 x64

Resolution: 1366x768

cc @kjozwiak @srirambv @LaurenWags @GeetaSarvadnya
@btlechowski btlechowski added this to the 0.55.x - Release Hotfix 2 milestone Oct 23, 2018
@btlechowski
Copy link
Author

btlechowski commented Oct 23, 2018 •
edited
Loading

No longer blocked by: #1805

@NejcZdovc
Copy link
Contributor

cc @jonathansampson @bradleyrichter

@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 30, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 30, 2018

@kjozwiak closing

@rebron rebron closed this as completed Oct 30, 2018
@rebron rebron modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 30, 2018
@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed OS/Windows OS/macOS labels Nov 5, 2018
@kjozwiak kjozwiak removed QA/Test-Plan-Specified QA/Yes feature/referral-promo priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 5, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Nov 5, 2018

Created https://github.com/brave/brave-website/issues/199 as discussed in the triage meeting.

@srirambv srirambv mentioned this issue Oct 19, 2018
Open
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jonathansampson @bbondy @kjozwiak @bsclifton @rebron @NejcZdovc @bradleyrichter @btlechowski