Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned tabs scroll away #17881

Closed
ygoe opened this issue Sep 5, 2021 · 5 comments
Closed

Pinned tabs scroll away #17881

ygoe opened this issue Sep 5, 2021 · 5 comments

Comments

@ygoe
Copy link

ygoe commented Sep 5, 2021

Description

Pinned tabs are just small but not pinned. When tab scrolling is enabled (through flags), which is IMO necessary to handle larger amounts of tabs, then the pinned tabs at the left end of the tab bar are simply scrolled away with all the other tabs. Firefox shows pinned tabs permanently, while scrolling all other tabs (without a special setting, it just scrolls as default).

Steps to Reproduce

  1. Enable tabs scroling in flags
  2. Pin tabs
  3. Open many tabs until scrolling is in effect

Actual result:

Pinned tabs scroll out of view

Expected result:

Pinned tabs remain visible all the time

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.29.77 Chromium: 93.0.4577.63 (Offizieller Build) (64-Bit)
Überarbeitung ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
Betriebssystem Windows 10 OS Version 2009 (Build 19042.1052)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? unknown
  • Can you reproduce this issue with the nightly channel? unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? yes

Miscellaneous Information:

What's the purpose of "pinned tabs" after all?

@ygoe ygoe added the OS/Desktop label Sep 5, 2021
@iam-cult
Copy link

iam-cult commented Sep 5, 2021

What's the purpose of "pinned tabs" after all?

Pinned tabs are preserved between browser sessions when normal tabs aren't.

@ygoe
Copy link
Author

ygoe commented Sep 5, 2021

Ah. Never noticed that as my default for productive browsers is always to restore the session on startup.

@rebron
Copy link
Collaborator

rebron commented Sep 9, 2021

Closing, not actionable. Experimental flags are experimental and not something we act on. Pinned tabs fix may get addressed as the tab scrolling feature gets developed.

@ygoe
Copy link
Author

ygoe commented Sep 10, 2021

Okay, so I guess nobody is interested in knowing that new tabs aren't completely visible either. When a new tab is opened (not the right-most one), the new tab header is moved out of the view by 2 or 3 pixels to the right. I haven't found out the exact circumstances yet.

Also, when tab scrolling is active, a small part left and right of the scroll container isn't painted when the browser window is activated or deactivated. My active title colour is blue and the inactive colour is white. When the browser is activated or deactivated, a part remains in the old colour until the tabs are scrolled again.

Where would be a place to report such bugs in "experimental" features? I mean, somebody is trying them out so they should be interested in knowing whether they work or not.

@JimB-Dev
Copy link

JimB-Dev commented Oct 2, 2021

Chromium project for this one I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants