Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show "30-day ads history" link button in Rewards settings page #16902

Closed
Miyayes opened this issue Jul 12, 2021 · 1 comment · Fixed by brave/brave-core#9675
Closed

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 12, 2021

Description

Currently, when 30-day ads history (or 7-day ads history previously) is empty, the 30-day ads history button/link in the bottom right corner of brave://rewards (Rewards settings page) does not appear.

image

(Note how it's missing in bottom-right corner.)

This doesn't train users to know that this feature exists.

Solution

  1. Always show 30-day ads history link/button, even when list is empty
  2. When list is empty, just put a message in there that says "You haven't seen any ads in the last 30 days."

Can get design input as well if needed, but let's iterate. cc: @codybanxs.

@stephendonner
Copy link

stephendonner commented Aug 7, 2021

Verified PASSED using

Brave 1.30.7 Chromium: 92.0.4515.131 (Official Build) nightly (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.1 (Build 20G80)

Steps:

  1. new profile
  2. launched Brave
  3. clicked Start using Rewards
  4. opened brave://rewards
  5. confirmed I saw 30-day Ads History link
  6. clicked on the link and confirmed I saw No ads viewed in the last 30 days.
  7. viewed an ad
  8. confirmed I saw the new ad appear after refreshing
  9. confirmed Ads I received this month is now 1, as expected too
example example example example
Screen Shot 2021-08-07 at 9 58 37 AM Screen Shot 2021-08-07 at 9 58 42 AM Screen Shot 2021-08-07 at 10 04 08 AM Screen Shot 2021-08-07 at 10 11 16 AM

Verification passed on

Brave 1.30.65 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS

Verified in Polish (PL)

Verified the 30 day history link is shown when there are 0 ads
image

Verified No ads viewed in the last 30 days. is translated in ads history
image


Verification passed on

Brave | 1.30.68 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Verified in Kannada locae
Verified the 30 day history link is shown when there are 0 ads
image
image

Viewed an Ad and seen the ads history
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment