-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase view from 7-day ad history to 30-day ad history #16627
Comments
Hi, I would like to work on this issue. Please guide me further where to make changes. |
This is a great idea! It will help a lot with trouble-shooting. Please also extend this feature to Android. |
@himanshu007-creator That's great you are enjoying Brave. Apologies, I just noticed you would have liked to work on this. |
Nevermind, I'll find some other low hanging fruit (easy issue)🙂 |
Setting as |
Verified
|
Brave | 1.28.96 Chromium: 92.0.4515.115 (Official Build) beta (x86_64) |
---|---|
Revision | 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4} |
OS | macOS Version 11.5.1 (Build 20G80) |
Also used for the migration cases were
Brave | 1.27.109 Chromium: 92.0.4515.115 (Official Build) (x86_64) |
---|---|
Revision | 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4} |
OS | macOS Version 11.5.1 (Build 20G80) |
Brave | 1.26.77 Chromium: 91.0.4472.164 (Official Build) (x86_64) |
---|---|
Revision | 541163496c9982c98f61819bab7cf2183ea8180f-refs/branch-heads/4472@{#1569} |
OS | macOS Version 11.5.1 (Build 20G80) |
1.28.96
:
Steps:
- new profile
- launched Brave
- enabled
Rewards
- viewed ads
- loaded
brave://rewards
- confirmed it says
30-day Ads History
and lists my ads - click on the above link
- confirmed the popup reads
Ads you've received in the past 30 days
- shut down Brave
- forwarded system clock 30 days
- launched Brave
- confirmed there's no ad history
- shut down Brave
- from today's date, forwarded system clock 29 days
- launched Brave
- confirmed
30-day ads history
returned
steps 6-8 | steps 6-8 | step 12 | step 16 | step 16 |
---|---|---|---|---|
1.27.109
and 1.26.77
:
Steps (for both):
- new profile
- launched Brave
- enabled
Rewards
- viewed ads
- loaded
brave://rewards
- confirmed it says
7-day Ads History
and lists my ads - upgraded builds to
1.28.96
- launched Brave
- loaded
brave://rewards
- confirmed and clicked on the
30-day Ads History
link - confirmed it says
30-day Ads History
and lists my ads
step 6 | step 6 | step 10 | step 11 |
---|---|---|---|
Description
Currently, ad history contains up to 7 days of ads. This should be increased to 30 days.
Solution
cc: @tmancey @lukemulks
The text was updated successfully, but these errors were encountered: