Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space needed before privacy-policy link text, in French translation of Brave Rewards' popup dialog #16580

Closed
stephendonner opened this issue Jun 23, 2021 · 0 comments
Assignees
Labels
feature/rewards l10n needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon".

Comments

@stephendonner
Copy link

Description

Space needed before privacy-policy link text, in French translation of Brave Rewards' popup dialog

Steps to Reproduce

  1. set OS region and language to France and French, respectively
  2. launch Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
  3. click on the BAT icon in the URL bar
  4. look at the resulting hanging dialog

Actual result:

There's a space character missing between et la and Politique... in En continuant, vous acceptez les Conditions d'utilisations et laPolitique de confidentialité.

example example
Capture d’écran 2021-06-23 à 14 30 21 Capture d’écran 2021-06-23 à 14 30 26

Expected result:

There should be a space between ...et la and Politique de confidentialité.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.77 Chromium: 91.0.4472.114 (Build officiel) beta (x86_64)
Révision 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
Système d'exploitation macOS Version 11.4 (assemblage 20F71)
@rebron rebron added l10n polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". needs-text-change This change requires some careful wording. labels May 18, 2022
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards l10n needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

4 participants