Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab grouping UI is wrong #14765

Closed
Stephcraft opened this issue Mar 16, 2021 · 8 comments
Closed

Tab grouping UI is wrong #14765

Stephcraft opened this issue Mar 16, 2021 · 8 comments
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/tabs-bar OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@Stephcraft
Copy link

Description

The new tab group feature has UI problems. The group name label is not rounded corner and it is not spaced properly with the grouped tabs. The grouped border of the selected tab in the group is bigger than all other tabs. I've attached an image of what it looks like vs what it looks like in chrome (great ui design)

Steps to Reproduce

  1. Open a couple tabs
  2. Right click on a tab > Add tab to group
  3. Give a name to the group

Actual result:

image

Expected result:

image

Reproduces how often:

Always reproduced

Brave version

1.21.77

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No, It looks good on chrome

Miscellaneous Information:

None

@not-a-dev-stein
Copy link

not-a-dev-stein commented Mar 17, 2021

Having the same issue here. I have used Ungoogled Chromium for a while before coming back to Brave yesterday, so it really weirded me out why this visual stuff is happening.

The best I'm able to do to deal with this for now is adding a space before and after the tab group name to have a little more proper spacing to the title.

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". design A design change, especially one which needs input from the design team labels Jun 3, 2021
@rebron rebron added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 3, 2021
@karenkliu
Copy link

@rebron No design mockups required; this is a feature fully ported over from Chromium and it should look like the expected result posted in the issue.

@jdsimcoe
Copy link

I've noticed this same border clipping issue (but only on system light mode). On dark mode the Tab Group stroke appears more standard:

image

@NeuronSooup
Copy link

I wonder if this 2 year old issues has been resolved yet? Oh that is right, it hasn't. Nevermind, I guess injecting Ads in Brave Search is more important

@jdsimcoe
Copy link

@NeuronSooup looks visually resolved to me
image

@Stephcraft
Copy link
Author

@NeuronSooup looks visually resolved to me image

That's true, some progress has been made, but there are still 3 mistakes:

1. In this case, everything is good, but perhaps we could have even more rounded corners for the label, so it stays consistent with the empty circle design:
image

image

2. When the window is maximized or/and the first tab of the group is selected, the edges touch:
image

3. When the last tab of the group is selected, the border is no longer rounded at the end (Like in your case):
image

vs

image

@jdsimcoe
Copy link

ah yeah that's weird

@Stephcraft
Copy link
Author

Let's goooo!!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/tabs-bar OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

6 participants