-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab grouping UI is wrong #14765
Comments
Having the same issue here. I have used Ungoogled Chromium for a while before coming back to Brave yesterday, so it really weirded me out why this visual stuff is happening. The best I'm able to do to deal with this for now is adding a space before and after the tab group name to have a little more proper spacing to the title. |
@rebron No design mockups required; this is a feature fully ported over from Chromium and it should look like the expected result posted in the issue. |
I wonder if this 2 year old issues has been resolved yet? Oh that is right, it hasn't. Nevermind, I guess injecting Ads in Brave Search is more important |
@NeuronSooup looks visually resolved to me |
That's true, some progress has been made, but there are still 3 mistakes: 1. In this case, everything is good, but perhaps we could have even more rounded corners for the label, so it stays consistent with the empty circle design: 2. When the window is maximized or/and the first tab of the group is selected, the edges touch: 3. When the last tab of the group is selected, the border is no longer rounded at the end (Like in your case): vs |
ah yeah that's weird |
Description
The new tab group feature has UI problems. The group name label is not rounded corner and it is not spaced properly with the grouped tabs. The grouped border of the selected tab in the group is bigger than all other tabs. I've attached an image of what it looks like vs what it looks like in chrome (great ui design)
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often:
Always reproduced
Brave version
1.21.77
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
None
The text was updated successfully, but these errors were encountered: