Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High memory consumption from Crypto Wallets #13438

Closed
ryanml opened this issue Jan 8, 2021 · 1 comment · Fixed by brave/KeyringController#14
Closed

High memory consumption from Crypto Wallets #13438

ryanml opened this issue Jan 8, 2021 · 1 comment · Fixed by brave/KeyringController#14

Comments

@ryanml
Copy link
Contributor

ryanml commented Jan 8, 2021

Description

Steps to Reproduce

  1. Clean profile, install crypto wallets
  2. Pre account creation, import, note relatively low memory usage of the Crypto Wallets extension (<=100mb)
  3. Create an account

Actual result:

  1. On the seed phrase recovery screen, note the very high memory usage (>=550mb)
  2. Note the continued high memory usage while using the extension, with spikes up after unlocking
    image (1)

Expected result:

Much more reasonable memory usage
Screen Shot 2021-01-07 at 8 18 13 PM

Reproduces how often:

100%

@srirambv
Copy link
Contributor

srirambv commented Jan 26, 2021

Verification passed on

Brave 1.20.89 Chromium: 88.0.4324.96 (Official Build) beta (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Linux
Component 1.0.22 Dev
  • Verified memory usage is low compared to before
    image

Verification passed on

Brave 1.19.86 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Windows 10 OS Version 2009 (Build 19042.746)
Component 1.0.22 Dev
  • Verified memory usage is low compared to before
    image

Verification passed on

Brave 1.21.21 Chromium: 88.0.4324.96 (Official Build) nightly (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 10.15.7 (Build 19H114)
Component 1.0.22 Dev
  • Verified memory usage is low compared to before
    image

Logged #13774 as a follow-up for investigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants