Rewards onboarding double overlay fix

[ghost]

Description

Currently if a user opens the rewards panel and dismisses the global overlay, a smaller opt-in UI is then also triggered underneath it to expose the same messaging again.

Steps to Reproduce

1. Open a clean browser install or upgrade with Rewards off
2. Tap the Rewards panel to see the global Rewards opt-in overlay
3. Dismiss the overlay and you will see a second dialog box with almost the same messaging
4. Closing that dialog will then show the full panel

Actual result:

Expected result:

Android Device details:

• Install type (ARM, x86): Arm
• Device type (Phone, Tablet, Phablet):Phone
• Android version: Nightly 1.20.60

[deeppandya]

@anthonypkeane @bsclifton where should we land this ? it's merged to 1.20 for now.

[bsclifton]

@deeppandya I think 1.20 works - we're pretty close to verifying 1.19
cc: @kjozwiak @LaurenWags just in case we did want this in 1.19

[LaurenWags]

1.20.x sounds good to me 👍🏻

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.20.85 x64 beta build

• Verified second onboarding overlay is not shown when the global onboarding is dismissed

ARM-Onboarding.mp4

---

Verification passed on Samsung Tab A with Android 10 running 1.20.85 x64 beta build

• Verified second onboarding overlay is not shown when the global onboarding is dismissed

Tab.Onboarding.mp4