Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user activity frequency capping #11858

Closed
tmancey opened this issue Sep 25, 2020 · 1 comment · Fixed by brave/brave-core#6703
Closed

Implement user activity frequency capping #11858

tmancey opened this issue Sep 25, 2020 · 1 comment · Fixed by brave/brave-core#6703

Comments

@tmancey
Copy link
Contributor

tmancey commented Sep 25, 2020

Implement user activity frequency capping as a pre-requisite for ad delivery timing

@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 25, 2020
@tmancey tmancey changed the title Implement Brave Ads bandits phase 1 Implement user activity frequency capping Sep 25, 2020
@tmancey tmancey added this to the 1.16.x - Nightly milestone Sep 29, 2020
@srirambv
Copy link
Contributor

srirambv commented Oct 1, 2020

Verification passed on OnePlus 6T with Android 10 running 1.15.69 x64 build

  • Verified ads is enabled when rewards is enabled
  • Verified number of ads shows as per settings
  • Verified ads is shown only when the browser is in use
  • Verified view/click/landed/dismiss is logged correctly

Verification passed on Samsung Tab A with Android 10 running 1.15.69 x64 build

  • Verified ads is enabled when rewards is enabled
  • Verified number of ads shows as per settings
  • Verified ads is shown only when the browser is in use
  • Verified view/click/landed/dismiss is logged correctly

Verification completed using below

Brave	1.15.69 Chromium: 86.0.4240.55 (Official Build) (x86_64)
Revision	a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified scenarios outlined in brave/brave-core#6703 (comment)

Verified ad is not shown on clean profile (0points)
Verified ad is not shown when 1 new tabs are open. (1point)
Verified ad is shown when 2 new tabs are open. (2points)
Verified ad is shown only when 1 new tab is opened and the focusing of tab is changed to another tab (2points)
Verified ad is shown after opening youtube video in a new tab (2points)
Verified ad is shown after browser becomes active and enters background 2times (2points)
Verified that score is reset after browser restart
Verified ad is not shown after opening youtube video in the same tab(1point)
Verified ad delivery for max 1, 2, 3, 4, 5 ads per hour setting


Verification passed on

Brave 1.15.69 Chromium: 86.0.4240.55 (Official Build) (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6703 (comment)

Verified ad is not shown on clean profile (0points)
Verified ad is not shown when 1 new tabs are open. (1point)
Verified ad is shown when 2 new tabs are open. (2points)
Verified ad is shown only when 1 new tab is opened and the focusing of tab is changed to another tab (2points)
Verified ad is shown after opening youtube video in a new tab (2points)
Verified ad is not shown after opening youtube video in the same tab(1point)
Verified ad is shown after browser becomes active and enters background 2times (2points)
Verified that score is reset after browser restart
Verified ad delivery for 2 ads per hour, 3 ads per hour, 4 ads per hour and 5 ads per hour is working as expected


Verification passed on


Brave | 1.15.69 Chromium: 86.0.4240.55 (Official Build) (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Verified the test plan from Implement user activity frequency capping brave-core#6703
  • Verified AD are number of Ads delivered as per the Ads settings
    Verified ad is not shown on clean profile (0points)
    Verified ad is not shown when 1 new tabs are open. (1point)
    Verified ad is shown when 2 new tabs are open. (2points)
    Verified ad is shown only when 1 new tab is opened and the focusing of tab is changed to another tab (2points)
    Verified ad is shown after opening youtube video in a new tab (2points)
    Verified ad is not shown after opening youtube video in the same tab(1point)
    Verified ad is shown after browser becomes active and enters background 2times (2points)
    Verified that score is reset after browser restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants