Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop][CW] Remove MetaMask from browser action button tooltip #11646

Closed
srirambv opened this issue Sep 10, 2020 · 1 comment · Fixed by brave/ethereum-remote-client#167
Closed

Comments

@srirambv
Copy link
Contributor

Description

Remove MetaMask from browser action button tooltip

Steps to Reproduce

  1. Download crypto wallet component
  2. Open brave://wallet
  3. Pin the browser action button and hover over it

Actual result:

image

Expected result:

Should not contain MM branding

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Linux
Component 1.0.21

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv
Copy link
Contributor Author

srirambv commented Sep 11, 2020

Verification passed on

Brave 1.15.46 Chromium: 85.0.4183.102 (Official Build) beta (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Linux
Component 0.1.75
  • Verified browser action button tooltip reads Crypto Wallets instead of MM
    image

Verification passed on

Brave 1.13.86 Chromium: 85.0.4183.102 (Official Build) (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Windows 10 OS Version 1809 (Build 17763.1457)
Component 0.1.75
  • Verified browser action button tooltip reads Crypto Wallets instead of MM
    image

Verification passed on

Brave 1.16.4 Chromium: 85.0.4183.102 (Official Build) nightly (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS macOS Version 10.15.5 (Build 19F101)
Component 0.1.75
  • Verified browser action button tooltip reads Crypto Wallets instead of MM
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment