Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Don't grey while playing #40

Closed
klauf opened this issue Jul 23, 2017 · 3 comments
Closed

[Feature] Don't grey while playing #40

klauf opened this issue Jul 23, 2017 · 3 comments

Comments

@klauf
Copy link

klauf commented Jul 23, 2017

Hi
Thanks a lot for this very useful app, from a father with 5 months experience :)
I noticed that once 'play' is pressed, the sound and sleep timer are greyed out and can't be modified until 'stop' is pressed.
Is there a reason for that? Would it be possible to keep them both active?
Cheers

@brarcher
Copy link
Owner

I'm glad that you have found the app useful. (:

As for the greying out, some background. This application was intended to be a simple, no frills, white noise generator. The simplest implementation I could come up with involved setting up what should be played, then playing it over and over until it should stop. There was no thought for the ability to change the playback midstream, as being able to setup the sound at the beginning fit what I was going for. Because of this, the inputs are greyed out once playback starts to inform the user that input changes are not supported during playback. In addition, to reduce the amount of CPU needed to play the sounds for long periods of time, right when playback starts if the lowpass filter is used a one-time transformation is made to the sound file selected. The resulting file is then played back over and over in a very simple way. This avoids needs to apply the filter continuously during playback. Allowing the filter or input to be adjusted on the fly would require re-computing the output file again.

Anyway, it is entirely possible to allow the inputs to be modified at will and have the played sounds be updated. It was just simpler to not worry about that for this app. I probably would not be interested in adding this ability, but if someone were interested in taking it on I could pull in their changes.

Back to your experience with the app, how successful did you find it in helping your baby sleep? Personally, I ended up not finding it that successful, but maybe my house is rather quiet or I was lucky and my son stays asleep on his own. (:

@klauf
Copy link
Author

klauf commented Jul 28, 2017

Thanks for the detailed explanation! I haven't tried the low freq filter yet. Maybe without it it would be quicker to switch song and/or change timer?

The Dryer works well when the baby is really tired but too excited to fall asleep on its own. Then 5 min dryer and it's done :) when it sleeps deeply I stop it, never used it during sleep.
Hence the reason I wanted to adapt the timer 'on the fly', I turned it on without limit, and once the baby was asleep I wanted to leave it 5 min -> had to stop for like 1/4sec, so as to select the time and play; that was enough for the baby to wake up again!

@brarcher
Copy link
Owner

brarcher commented Aug 2, 2017

At least the part of this issue relating to the timer should now be resolved in the latest release. Likely I'll not get to enabling switching of audio files during playback, though certainly if anyone were interested in contributing this change I could accept it. If the work done for the timer is sufficient for what you need, then I'll consider this issue resolved. If not, please re-open this issue.

@brarcher brarcher closed this as completed Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants