Issue #252 - BraintreeFragment with child FragmentManager. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnjn
reviewed
May 27, 2019
| return newInstance(activity, activity.getSupportFragmentManager(), authorization); | ||
| } | ||
|
|
||
| public static BraintreeFragment newInstance(Context context, FragmentManager fragmentManager, String authorization) |
There was a problem hiding this comment.
What about a public method for passing a Fragment?
This function would be a private method that both our public newInstance would delegate to.
There was a problem hiding this comment.
Haha. Actually, that was my initial idea. I thought you'd like this one as the public API. Making the change...
zsoltvilagos
force-pushed
the
master
branch
2 times, most recently
from
e68c925 to
2d214f9
Compare
quinnjn
approved these changes
May 29, 2019
…agmentManager).
|
Fixed. Green again. |
|
@quinnjn Any news? If I might ask. |
|
Hi @zsoltvilagos. Looks like those additions to the Our main Android dev @quinnjn has been busy helping with some other teams, so I don't want to merge without his final stamp of approval! |
|
@scannillo Thx for the update. |
|
Sorry for the delay. Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for issue #252 , attaching BraintreeFragment to a child FragmentManager so that the instance can stay in the scope of a Fragment hosted by an Activity.