Include cause in ConfigurationException #143
Conversation
|
Hi @brianguertin! Thanks for the PR! I'm intrigued that you had to debug something in |
|
Oh, just noticed your comment. The reason I want to differentiate is because I prefer handle network connectivity issues in a different manner (E.g. informing the user they are offline or have no internet connectivity). I also ensure that general connectivity issues don't raise alerts in our app's bug tracking tools (because lack of internet is not a bug that needs fixing). Currently, So in production, most |
| @@ -4,6 +4,9 @@ | |||
| * Error class thrown when a configuration value is invalid | |||
| */ | |||
| public class ConfigurationException extends BraintreeException { | |||
| public ConfigurationException(String message, Throwable cause) { | |||
There was a problem hiding this comment.
Needs a new line before this line.
| @@ -4,6 +4,9 @@ | |||
| * Error class thrown when a configuration value is invalid | |||
| */ | |||
| public class ConfigurationException extends BraintreeException { | |||
| public ConfigurationException(String message, Throwable cause) { | |||
| super(message, cause); | |||
| } | |||
There was a problem hiding this comment.
Needs a new line after this line.
|
Thanks again for the PR @brianguertin! Just two whitespace changes and we'll get this merged in. |
So, for debugging purposes, I would prefer to know the cause of this exception when there is one, and I don't see any harm in including it :)