Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Force all atlas 3D meshes to be in consistent "brainglobe" space, aligned to the annotations #213

Closed
Tracked by #217
dbirman opened this issue Oct 9, 2023 · 4 comments · Fixed by #305
Labels
atlasgen Issue was transferred from the retired bg-atlasgen. Concerns the atlas_generation submodule. enhancement New feature or request

Comments

@dbirman
Copy link

dbirman commented Oct 9, 2023

The annotation volumes are set up so that the origin (0,0,0) is at the front/left/top corner. Some of the 3D mesh files are aligned with this so that the origin in 3D space is also at this same point (e.g. see the CCF files), but many of the atlases are not (see e.g. the human atlas or AZBA). It's possible to apply the trasform_to_brainglobe affine transform to move the brains to the correct position in some cases, but in other cases the transform appears to be incorrect.

It would be a big benefit for users to simply move all the 3D meshes into the annotation space for consistency (i.e. so that the transform is the identity matrix with a (0,0,0) translation)

@dbirman dbirman added the enhancement New feature or request label Oct 9, 2023
@adamltyson
Copy link
Member

There was a reason why this wasn't enforced originally, but I can't think what this was. This is a good idea, and I'm transferring this to the atlas generation repo.

@adamltyson adamltyson transferred this issue from brainglobe/brainglobe-atlasapi Oct 9, 2023
@willGraham01 willGraham01 added the atlasgen Issue was transferred from the retired bg-atlasgen. Concerns the atlas_generation submodule. label Feb 23, 2024
@willGraham01 willGraham01 transferred this issue from brainglobe/bg-atlasgen Feb 23, 2024
This was referenced May 16, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Core development May 23, 2024
@adamltyson
Copy link
Member

Thanks for raising this @dbirman. The problems with those two specific atlases have now been fixed, and we're working through all the others.

@dbirman
Copy link
Author

dbirman commented May 23, 2024

Amazing! I'll add the human atlas and AZBA to Pinpoint then, if there's a way to be notified when the other atlases are fixed I'd appreciate it so I can trigger the compile process for adding them to Pinpoint as well. Thanks!

@adamltyson
Copy link
Member

So far updated versions have been released for azba_zfish, allen_human (this now has both hemispheres too), perens_lsfm_mouse and kim_mouse.

Shall we just post on the zulip when new versions are released @viktorpm, @alessandrofelder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atlasgen Issue was transferred from the retired bg-atlasgen. Concerns the atlas_generation submodule. enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants