Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Remove HTML file checking in setDocInfo #3023

Open
core-ai-bot opened this issue Aug 29, 2021 · 1 comment
Open

[CLOSED] Remove HTML file checking in setDocInfo #3023

core-ai-bot opened this issue Aug 29, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by jrowny
Friday Mar 22, 2013 at 15:42 GMT
Originally opened as adobe/brackets#3218


Now that the static server exists, I believe that checking for type should be done by the canServe function of the provider. The StaticProvider already checks for HTML extension, so this line of code can not be executed anyway. This is a temporary fix as a longer term re-factoring is need.


jrowny included the following code: https://github.com/adobe/brackets/pull/3218/commits

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Mar 26, 2013 at 21:03 GMT


The intent for the code being changed here is to prevent user from using Live Dev on non-HTML files, but that is apparently being prevented elsewhere, because I cannot find anything that is broken with this change.

Looks good. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant