Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Preference to change new font rendering #2646

Open
core-ai-bot opened this issue Aug 29, 2021 · 9 comments
Open

[CLOSED] Preference to change new font rendering #2646

core-ai-bot opened this issue Aug 29, 2021 · 9 comments

Comments

@core-ai-bot
Copy link
Member

Issue by drewhamlett
Monday Feb 04, 2013 at 16:45 GMT
Originally opened as adobe/brackets#2791


Need preference or easy to way to get font rendering the way it was in Sprint 19 and below. If it messes up animation then have a setting to disable animation.

I feel like I'm on XP again

Also just add, none of the other editors I've used on MacOSX render fonts that light by default. Food for thought. I know there are animation issues but those could be disabled.

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Feb 07, 2013 at 23:43 GMT


FYI, the animation issues are specifically because Brackets is built as a web app using Chromium, and the animations are done using CSS.

Marking move to backlog for now. If we get similar feedback from others once we release sprint 20, we might want to move this higher up on the backlog.

@core-ai-bot
Copy link
Member Author

Comment by drewhamlett
Tuesday Feb 12, 2013 at 22:09 GMT


So when sprint 20 get's released how will I change the font rendering back? Is it just in one place or a few?

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Tuesday Feb 12, 2013 at 23:21 GMT


This is the pull request where font was updated: adobe/brackets#2665

The entire font was updated, but I think that you might just be able to change this setting on brackets.less line 62 from:

  -webkit-font-smoothing: antialiased;

to:

-webkit-font-smoothing: subpixel-antialiased;

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday Feb 12, 2013 at 23:59 GMT


That will switch the antialiasing, but you'll still be using the heavier font that we introduced. To go back to the original font, you also need to remove the font-family entry from .code-font-mac() in brackets_theme_default.less.

@core-ai-bot
Copy link
Member Author

Comment by drewhamlett
Wednesday Feb 13, 2013 at 02:43 GMT


Thanks guys. All is looking good in CM3 Preview version. Not exactly the same but close. Main difference is the gutter is padded out a little. Font is a little different. Less spacing in the letters CM3 test version. Letters may be too scrunched up in my opinion.

Real test is when I get on thunderbolt monitor tomorrow.

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday May 10, 2013 at 20:23 GMT


@drewhjava - closing this out for now. Let us know if you still have issues with the font rendering.

@core-ai-bot
Copy link
Member Author

Comment by drewhamlett
Friday May 10, 2013 at 23:05 GMT


@njx I've just been changing it manually every release. Haha. Maybe in future it will be easy to code out as an extension or something. Thanks.

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday May 10, 2013 at 23:16 GMT


Oh :) Well, you could conceivably write an extension to just change the antialiasing by dynamically creating a <style> block with body { -webkit-font-smoothing: subpixel-antialiased !important; }. The only issue is you'll be getting our current font weight, which is slightly bolder than the old font weight, so you'd probably need to override that manually too. Eventually we'll make fonts configurable...

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday May 10, 2013 at 23:17 GMT


(Or, for the first hack, you might even be able to just do $(document.body).css("-webkit-font-smoothing", "subpixel-antialiased").)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant