Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Opening certain folders in the file navigator throws exceptions and the folder fails to open #23

Open
core-ai-bot opened this issue Aug 29, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by tvoliter
Friday Dec 16, 2011 at 23:25 GMT
Originally opened as adobe/brackets#19


  1. Launch branckets
  2. Choose "Applications" as your root directory
  3. Try to open various folders. On my machine quite a few of them fail to open and the console shows exceptions.

The exceptions are coming form the definition of brackets.fs.readdir in brackets_extensions.js. It looks like JSON.parse doesn't like some of the JSON we are passing it

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Dec 17, 2011 at 00:23 GMT


I can repro this with certain weird files which cause the Brackets.app native file APIs to create malformed JSON.

For example, this repros for me with one of the files inside the "Adobe Wireless Setup.app" folder. In Finder, the file is hidden (but if I show hidden files, it appears as a grayed-out file named "Icon"). In Terminal, the filename appears to be "Icon?", but I assume that's impossible since "?" is a wildcard. In the JSON Brackets.app generates, we get a CR character instead of a "?", which is illegal inside of a string literal and thus breaks the JSON string.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Dec 17, 2011 at 00:37 GMT


Seems to always happen wit the hidden "Icon" file inside app packages (or any other folder with a customized icon). I can get this with all the various Adobe CS apps' folders, for example, since they all have custom folder icons.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Saturday Dec 17, 2011 at 01:54 GMT


Replaced with adobe/brackets-app#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant