Find in Files error message is not cleared when filter changes

[core-ai-bot]

Issue by redmunds
Wednesday Nov 19, 2014 at 23:18 GMT
Originally opened as adobe/brackets#9974

---

Recipe

1. Do a Find in Files and add an exclusion for */thirdparty/*
2. Switch to brackets repo
3. Right click on a folder inside thirdparty folder and select "Find in..."
4. Execute a search
5. Verify error message "Filter excludes all files in project"
6. This is correct because last exclusion is remembered
7. Change to "Don't Exclude Files"

Result
"Filter excludes all files in project" message is still displayed. This is disconcerting. This actually cannot be determined until the search is initiated (same as with initial search).

Expected
Message should be dismissed on any change to filter until that case is hit again.

Also
I just noticed that error message says project, which is incorrect since I searched on a folder.

[core-ai-bot]

Comment by hzahoori
Friday Dec 05, 2014 at 19:15 GMT

---

Hi@redmunds and@peterflynn can I work on this bug please?

[core-ai-bot]

Comment by redmunds
Friday Dec 05, 2014 at 19:29 GMT

---

@hzahoori I am not aware of anyone else working on this, so go for it!

[core-ai-bot]

Comment by hzahoori
Friday Dec 05, 2014 at 20:33 GMT

---

Thank You@redmunds , I will start working on it..

[core-ai-bot]

Comment by peterflynn
Friday Dec 05, 2014 at 23:07 GMT

---

@redmunds Your note about the string being wrong is UTR for me. I see "Filter excludes all files in " -- it only shows "Filter excludes all files in project" when you have no folder scope applied. The code in FindInFilesUI.searchAndShowResults() that picks which string to show sure looks correct to me...

[core-ai-bot]

Comment by redmunds
Saturday Dec 06, 2014 at 00:23 GMT

---

I just reproduced it again. Then I started to grab some screen shots and now I can't repro to save my life! Apparently it requires a precise set of steps that I have not yet nailed down. Good thing is that it usually works correctly.

[core-ai-bot]

Comment by hzahoori
Saturday Dec 06, 2014 at 00:27 GMT

---

So@redmunds and@peterflynn do you want me to wait yet?

[core-ai-bot]

Comment by peterflynn
Saturday Dec 06, 2014 at 00:45 GMT

---

@hzahoori The main bug described here (message not being hidden) is still easily reproducible, so I don't think there's any reason to hold off on looking at that part.

[core-ai-bot]

Comment by sriram-dev
Tuesday Jan 13, 2015 at 16:11 GMT

---

Steps for recreating the second part of the issue.
Error message displays project instead of current folder.

1. Do a Find in Files on any of thirdparty subfolders without exclusions
2. Search for something which will yield atleast one result.
3. Do a Find In files again on same sub folder and Add /thirdparty/ exclusion now.
4. Search for something and you will see project instead of folder name in error message.

[yashs33244]

I have tried to recreate it but it does not show error with file name if I search with exclusion /thirdparty/
else I also see the project.

• Original issue says the exclusion must be /thirdparty/

• And it is working fine with this exclusion(*/thirdparty/*).

[charlypa]

@yashs33244 Brackets have been moved to new project phoenix code. Try new Phoneix Code and see if its still an issue
https://phcode.dev/