Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Do not run jshint tasks twice #10109

Open
core-ai-bot opened this issue Aug 30, 2021 · 3 comments
Open

[CLOSED] Do not run jshint tasks twice #10109

core-ai-bot opened this issue Aug 30, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ficristo
Saturday Sep 05, 2015 at 16:49 GMT
Originally opened as adobe/brackets#11664


Small cleanup.


ficristo included the following code: https://github.com/adobe/brackets/pull/11664/commits

@core-ai-bot
Copy link
Member Author

Comment by nethip
Tuesday Sep 08, 2015 at 07:39 GMT


Thanks@ficristo ! Looks good. Merging.

@core-ai-bot
Copy link
Member Author

Comment by le717
Tuesday Sep 08, 2015 at 19:20 GMT


The :all subtask was present to run all the test suites (src, test, and grunt) all at one time instead of having to run each one individually. With this change, did you confirm running grunt test runs all the suites like before? Also, how were the JSHint subtasks being run twice as there was only one call to run them (jshint:all)?

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Thursday Sep 10, 2015 at 18:26 GMT


@le717 If you omit the subtask ("all" in this case) jshint run all the tasks defined.
This change impact who run jshint alone (so they do not need to remember the subtask), and the "watch:all" task that now do not run jshint twice.
I confirm that |grunt test| run the same suites as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant