Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop container can easily cause the entire page to overflow.Can you add fill to currentcolor for the icon to facilitate color setting #277

Closed
zxuanhong opened this issue Aug 25, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@zxuanhong
Copy link

zxuanhong commented Aug 25, 2023

Describe the Bug

  1. The bullet frame should not be mounted under the root body.This can cause penetration out of the container, resulting in a page overflow
  2. The top left icon color should be modifiable to fit the dark mode
image

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS] chrome 110
  • OS: [e.g. Windows 7] mac
  • Library version: [e.g. 2.0.0] 3.3.2
@zxuanhong zxuanhong added the bug Something isn't working label Aug 25, 2023
@zxuanhong zxuanhong changed the title Pop-ups can easily cause the entire page to overflow.Can you add fill to currentcolor for the icon to facilitate color setting pop container can easily cause the entire page to overflow.Can you add fill to currentcolor for the icon to facilitate color setting Aug 25, 2023
@zxuanhong zxuanhong changed the title pop container can easily cause the entire page to overflow.Can you add fill to currentcolor for the icon to facilitate color setting Pop container can easily cause the entire page to overflow.Can you add fill to currentcolor for the icon to facilitate color setting Aug 25, 2023
@nikku
Copy link
Member

nikku commented Aug 28, 2023

CC @pinussilvestrus. Maybe you can have a look?

@zxuanhong
Copy link
Author

And how do I disable this pop-up

@christian-konrad
Copy link

@zxuanhong simply hide it's activating button via

.bio-properties-panel-group-entries button.bio-properties-panel-open-feel-popup {
  display: none;
}

@christian-konrad
Copy link

@zxuanhong you can easily change colors of the drag icon with css filters

@zxuanhong
Copy link
Author

@christian-konrad I think it's easier to set up with currentColor

@pinussilvestrus
Copy link
Contributor

The bullet frame should not be mounted under the root body.This can cause penetration out of the container, resulting in a page overflow

With #280 we aim to add an option to configure the parent container of the popup editor.

@zxuanhong
Copy link
Author

@pinussilvestrus I only used bpmn js, so need to adjust the bpmn-js-properties-panel component configuration

@pinussilvestrus
Copy link
Contributor

@zxuanhong this option will be present via bpmn-io/bpmn-js-properties-panel#970 in bpmn-js-properties-panel as well

@zxuanhong
Copy link
Author

@pinussilvestrus Thank you very much. I think there should be no problem only to set up, so I will close the current issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants