Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ethers as an optional peer dependency + import it dynamically #113

Closed
bpierre opened this issue Jun 14, 2021 · 0 comments · Fixed by #153
Closed

Add Ethers as an optional peer dependency + import it dynamically #113

bpierre opened this issue Jun 14, 2021 · 0 comments · Fixed by #153

Comments

@bpierre
Copy link
Owner

bpierre commented Jun 14, 2021

Peer dependencies can be declared as optional by using the peerDependenciesMeta field (supported by Yarn).

Having Ethers as an optional peer dependency and importing it dynamically (through import()) could remove the need for app authors to inject it themselves and simplify configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Ethers an optional peer dependency bpierre/use-nft
1 participant
@bpierre