From 8598df44e5af6976c60931350ab1a02a64764eef Mon Sep 17 00:00:00 2001
From: Ian Jenkins <ian.jenkins@boxuk.com>
Date: Fri, 23 Apr 2021 11:00:32 +0100
Subject: [PATCH] [BUG] Fix subdomain install adding extra site.

When using a subdomain install, an extra site was being created when the
site key was an empty string, e.g.

example.com
.example.com
sub.example.com

When desired outcome is:

example.com
sub.example.com

This PR updates it so that for subdomain installs, if the site key is an
empty string it will no longer create a site with an empty prefix.
---
 features/network-sites.feature      | 34 +++++++++++++++++++++++++++++
 php/regions/class-network-sites.php | 11 ++++++++--
 2 files changed, 43 insertions(+), 2 deletions(-)

diff --git a/features/network-sites.feature b/features/network-sites.feature
index 3080e19..3048417 100644
--- a/features/network-sites.feature
+++ b/features/network-sites.feature
@@ -63,3 +63,37 @@ Feature: Network Sites Region
       """
       en_GB
       """
+
+  Scenario: Impose Network Sites with subdomains with main site without a subdomain
+    Given a WP multisite subdomain install
+    And a network-state.yml file:
+      """
+      state: network
+      sites:
+        :
+          title: Main site
+          description: This is the main site with no subdomain required
+          active_theme: p2
+          active_plugins:
+            - akismet/akismet.php
+          timezone_string: Europe/London
+          WPLANG: en_GB
+        sub:
+          title: Sub site
+          description: This is the sub site with a subdomain of 'sub' required
+          active_theme: p2
+          active_plugins:
+            - akismet/akismet.php
+          timezone_string: Europe/London
+          WPLANG: en_GB
+      """
+
+    When I run `wp dictator impose network-state.yml`
+    Then STDOUT should not be empty
+
+    When I run `wp site list --field=url`
+    Then STDOUT should be:
+      """
+      http://example.com/
+      http://sub.example.com/
+      """
diff --git a/php/regions/class-network-sites.php b/php/regions/class-network-sites.php
index 9f180fc..e236479 100644
--- a/php/regions/class-network-sites.php
+++ b/php/regions/class-network-sites.php
@@ -98,6 +98,9 @@ public function get_differences() {
 	 * @return true|WP_Error
 	 */
 	public function impose( $key, $value ) {
+		if ( $key === '' ) {
+			$key = get_current_site()->domain;
+		}
 
 		$site = $this->get_site( $key );
 		if ( ! $site ) {
@@ -346,8 +349,12 @@ protected function create_site( $key, $value ) {
 		}
 
 		if ( is_subdomain_install() ) {
-			$path      = '/';
-			$newdomain = $base . '.' . preg_replace( '|^www\.|', '', $network->domain );
+			$path   = '/';
+			$prefix = '';
+			if ( $base !== '' ) {
+				$prefix = $base . '.';
+			}
+			$newdomain = $prefix . preg_replace( '|^www\.|', '', $network->domain );
 		} else {
 			$newdomain = $network->domain;
 			$path      = '/' . trim( $base, '/' ) . '/';