Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move SDK default to Twoliter.toml #3492

Closed
1 task done
webern opened this issue Sep 28, 2023 · 1 comment
Closed
1 task done

move SDK default to Twoliter.toml #3492

webern opened this issue Sep 28, 2023 · 1 comment
Assignees
@webern
Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo area/tools Issues in the build, publishing or other tooling1 or scripts

Comments

@webern
Copy link
Contributor

webern commented Sep 28, 2023 •
edited
Loading

What I'd like:

Once this is done

we need to stop specifying the SDK in Makefile.toml and instead specify it in Twoliter.toml.

Definition of Done

When the Bottlerocket build is using the SDK specified in Twoliter.toml and not specifying it in Makefile.toml.
@webern webern added area/tools Issues in the build, publishing or other tooling1 or scripts area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo labels Sep 28, 2023
@webern webern self-assigned this Sep 28, 2023
@webern
Copy link
Contributor Author

webern commented Oct 6, 2023

Done in #3480

@webern webern closed this as completed Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@webern webern

Labels
area/out-of-tree-builds Related to the efforts of making it easy to create builds outside of the main Bottlerocket repo area/tools Issues in the build, publishing or other tooling1 or scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@webern