-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apiclient: update tokio-tungstenite to v0.16.1+ #1947
Comments
The reason why this was happening is because apiserver sends the "exec'd" process's exit code inside the close frame as the close code. See: bottlerocket/sources/api/apiserver/src/server/exec.rs Lines 351 to 359 in 9749af9
But on the client side, This is problematic because any closing frame with a close code that's not allowed by To fix this issue with v0.16 of |
I guess to completely work around the protocol violation warning message when |
In v0.16.0 of
tungstenite
, the closing frame received by the client gets echoed back and returned to the user. Before it always returned a closing frame with a normal close code and empty string for the reason. With this behavior change we've seen some instances whereapiclient exec
would return non-zero exit codes regardless of the command result due to the receiving the closing frame with a disallowed code indicating protocol violation. We need to look intoapiserver
and figure what's going on there to fix the issue more permanently.The text was updated successfully, but these errors were encountered: