Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

early-boot-config: Use local file in sequence with other user data retrieval methods #1457

Closed
zmrow opened this issue Apr 5, 2021 · 0 comments · Fixed by #1576
Closed

early-boot-config: Use local file in sequence with other user data retrieval methods #1457

zmrow opened this issue Apr 5, 2021 · 0 comments · Fixed by #1576
Labels
area/core Issues core to the OS (variant independent) type/enhancement New feature or request
Milestone

Comments

@zmrow
Copy link
Contributor

zmrow commented Apr 5, 2021

Currently, using a local file (/etc/early-boot-config/user-data) for user data is supported in aws-dev. It is an implementer of the PlatformDataProvider trait. In main(), we decide to use either local file or another provider because we expect a PlatformDataProvider trait object.

We should be able to use local file and another provider's methods. In order to do this, I think we should move local file support to a shared function that returns Result<Option<SettingsJson>> so it can be used in sequence with other methods.

@jhaynes jhaynes added area/core Issues core to the OS (variant independent) priority/p1 type/enhancement New feature or request status/needs-triage Pending triage or re-evaluation and removed status/notstarted labels Apr 8, 2021
@jhaynes jhaynes added this to the backlog milestone Apr 9, 2021
@jhaynes jhaynes added status/notstarted and removed status/needs-triage Pending triage or re-evaluation labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Issues core to the OS (variant independent) type/enhancement New feature or request
Projects
None yet
3 participants