Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop hardcoding API constants across several programs #123

Closed
zmrow opened this issue Jul 31, 2019 · 0 comments · Fixed by #1709
Closed

Stop hardcoding API constants across several programs #123

zmrow opened this issue Jul 31, 2019 · 0 comments · Fixed by #1709
Assignees
@arnaldo2792
Labels
type/enhancement New feature or request
Milestone
next

Comments

@zmrow
Copy link
Contributor

zmrow commented Jul 31, 2019 •
edited by etungsten
Loading

Currently we have a few constants sprinkled around early-boot-config/sundog/tbs, etc. There needs to be a configuration crate or package where we can centralize these.

This package would contain things like:

  • datastore path
  • api address/socket
  • ...
@tjkirch tjkirch added the type/enhancement New feature or request label Oct 2, 2019
@iliana iliana changed the title Create configuration crate/package Stop hardcoding API constants across several programs Jan 23, 2020
@gregdek gregdek added this to the backlog milestone Apr 1, 2021
@arnaldo2792 arnaldo2792 self-assigned this Jul 27, 2021
@arnaldo2792 arnaldo2792 modified the milestones: backlog, next+1 Jul 27, 2021
@arnaldo2792 arnaldo2792 mentioned this issue Aug 11, 2021
Merged
@arnaldo2792 arnaldo2792 linked a pull request Aug 11, 2021 that will close this issue
Add constants crate #1709
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnaldo2792 arnaldo2792

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

Add constants crate arnaldo2792/bottlerocket
4 participants
@tjkirch @gregdek @zmrow @arnaldo2792