Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HTTP_PROXY environment variable configuration into various services #1178

Closed
yeolahm opened this issue Oct 22, 2020 · 1 comment · Fixed by #1204
Closed
Assignees
Labels
type/enhancement New feature or request

Comments

@yeolahm
Copy link

yeolahm commented Oct 22, 2020

What I'd like:
I would like to add HTTP_PROXY related environment variables to the various services (example - kubelet & containerd/docker) configuration files so that they can connect to the internet through the proxy server.

May be global configuration that allows HTTP_PROXY environment variables and parameter in each service to enable global config.

Any alternatives you've considered:
No, as I understand, by design it is not possible to dynamically add any configuration that does not exist into the data models

@srgothi92 srgothi92 assigned srgothi92 and unassigned srgothi92 Oct 22, 2020
@bcressey
Copy link
Contributor

Notes to check my understanding:

Goal is only to enable proxy usage for host level components (containerd, kubelet, host-ctr). We do not need to worry about injecting the variables into pod enviroments.

kubelet may or may not need a proxy in an EC2 VPC if connecting to the private IP of the API server. May need to special case this somehow, e.g. a default value for NO_PROXY that includes the API server hostname. Fallback would be separate proxy settings for kubelet, containerd in addition to global settings.

Web proxy URIs may contain user credentials. Since they will be rendered via template into configuration files under /etc, or dynamically set in the environment where they can be obtained from /proc/<pid>/environ, there's no immediate expectation that these settings will be stored in an encrypted form in the datastore.

@etungsten etungsten self-assigned this Nov 10, 2020
@jhaynes jhaynes added this to the v1.0.3 milestone Nov 10, 2020
@samuelkarp samuelkarp added the type/enhancement New feature or request label Nov 11, 2020
@etungsten etungsten linked a pull request Nov 11, 2020 that will close this issue
3 tasks
@tjkirch tjkirch removed this from the v1.0.3 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants