Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show stack name on list #30

Merged
merged 1 commit into from
Jun 26, 2014
Merged

Show stack name on list #30

merged 1 commit into from
Jun 26, 2014

Conversation

danielfrg
Copy link

Amazing plugin I have been using it for a couple of days and I love it. Thanks :)

Since I use stacks to group some of my notebooks i made a little change to include the name of the stack on the selection pane. I also tried to sort the notebook by name but the some notebooks opened the wrong notebook, maybe you can help me with that i think it could be a nice setting.

Thanks!

@bordaigorl
Copy link
Owner

Hey thanks! Sounds like a good idea!
I think I'll incorporate this in next release although maybe with a setting to turn this on and off (or maybe overkill?)

@bordaigorl bordaigorl added this to the Version 2.5.2 milestone Jun 25, 2014
@danielfrg
Copy link
Author

I was thinking a setting for sorting the notebooks by name but you could also have a setting for the showing the stack name.

bordaigorl pushed a commit that referenced this pull request Jun 26, 2014
Show stack name on list
@bordaigorl bordaigorl merged commit 628886e into bordaigorl:master Jun 26, 2014
@bordaigorl
Copy link
Owner

@danielfrg Have a look at commit 0bac4b4
I introduced the show/sort settings and more uniform displaying.
Hope you like it 😄

@danielfrg
Copy link
Author

Thanks you! But I think there is a bug if you sort the notebooks. It messes up the selection of the notebooks. What I mean is that on some notebooks it opens the notes of another notebook.

Maybe is because you are using the index of the list to open the correct notes and the sort changes the index, not sure though.

@bordaigorl
Copy link
Owner

That's right! Too rushed :bowtie: see commit 6c3fe0c
(it's also more efficient this way)

@danielfrg
Copy link
Author

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants