Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving annotation editor to editor package #1706

Open
glopesdev opened this issue Mar 7, 2024 · 1 comment
Open

Consider moving annotation editor to editor package #1706

glopesdev opened this issue Mar 7, 2024 · 1 comment
Labels
proposal Request for a new feature

Comments

@glopesdev
Copy link
Member

glopesdev commented Mar 7, 2024

Currently the enhanced annotation editor is implemented in the Bonsai.Design package. This is not ideal, as it brings in specific dependencies, i.e. Scintilla.NET which end up being unnecessarily propagated to downstream consumers of the design infrastructure.

A better solution would be to have this editor implemented as part of the Bonsai.Editor package, and change the AnnotationBuilder component editor to reference this new editor type; or simply remove the editor attribute altogether and have the component editor be injected via the workflow editor form itself. This would work since the AnnotationBuilder is a known core type which the editor assembly can know about.

@glopesdev glopesdev added bug Something isn't working proposal Request for a new feature labels Mar 7, 2024
@glopesdev glopesdev added this to the 2.9 milestone Mar 7, 2024
@glopesdev
Copy link
Member Author

Alternatively we can investigate switching the dependency to fernandreu/ScintillaNET which provides a .NET 6.0 compatible fork with a published NuGet package.

@glopesdev glopesdev removed the bug Something isn't working label Jul 16, 2024
@glopesdev glopesdev reopened this Jul 22, 2024
@glopesdev glopesdev removed this from the 2.9 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Request for a new feature
Projects
None yet
Development

No branches or pull requests

1 participant