Only skip htmlsnippets if we are returning a cached response #5121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -562,7 +562,7 @@ public function afterHandler(Request $request, Response $response) | |||
|
|
|||
| // true if we need to consider adding html snippets | |||
| // note we exclude cached requests where no additions should be made to the HTML | |||
| if (isset($this['htmlsnippets']) && ($this['htmlsnippets'] === true) && ($this['config']->get('general/caching/request') == false)) { | |||
| if (isset($this['htmlsnippets']) && ($this['htmlsnippets'] === true) && ($response->headers->get('Cache-Control') == "no-cache")) { | |||
| // only add when content-type is text/html | |||
There was a problem hiding this comment.
Just say "NO!" to loose comparison. 😉
There was a problem hiding this comment.
Gaaah, I fixed it in our deployment but copypasted the wrong version :D
We set the cache-control here: https://github.com/bolt/bolt/blob/2236c27440a4c52ca47591b1fba338cbc641f406/src/Render.php#L102 so if it is not set to a max-age we can be sure that we need to add the snippets.
|
Only failing on PHP 5.3, so GTG!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set the cache-control here:
bolt/src/Render.php
Line 102 in 2236c27