Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the ixdtf crate for datetime parsing #39

Closed
jedel1043 opened this issue Apr 14, 2024 · 3 comments · Fixed by #50
Closed

Migrate to the ixdtf crate for datetime parsing #39

jedel1043 opened this issue Apr 14, 2024 · 3 comments · Fixed by #50
Assignees
Labels
C-enhancement New feature or request
Milestone

Comments

@jedel1043
Copy link
Member

Right now the ixdtf crate is just a placeholder, but @nekevss migrated the parser to the ICU4X repo on unicode-org/icu4x#4646. We should migrate to that when the next version of ixdtf releases.

@jedel1043 jedel1043 added C-enhancement New feature or request blocked Waiting for some code change labels Apr 14, 2024
@jedel1043 jedel1043 added this to the 0.1 Blocking milestone Apr 14, 2024
@jedel1043
Copy link
Member Author

Unblocked since [email protected] has been published :)

@jedel1043 jedel1043 removed the blocked Waiting for some code change label May 29, 2024
@jedel1043
Copy link
Member Author

@nekevss are you planning to work on this?

@nekevss
Copy link
Member

nekevss commented May 29, 2024

@nekevss are you planning to work on this?

Yeah, I'll migrate us over.

I don't think I had realized it was part of the most recent release and unicode-org/icu4x#4918 is still up for review 😅 The core API shouldn't change though to much, so it should be fine to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants