Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate/Reevaluate the execution semantics of CompletionRecord #2675

Open
nekevss opened this issue Mar 16, 2023 · 0 comments
Open

Evaluate/Reevaluate the execution semantics of CompletionRecord #2675

nekevss opened this issue Mar 16, 2023 · 0 comments
Labels
E-Medium Medium difficulty problem vm Issues and PRs related to the Boa Virtual Machine.

Comments

@nekevss
Copy link
Member

nekevss commented Mar 16, 2023

As mentioned in PR #2618, we have previously been evaluating Return statements as normal completions and Yield statements a non-normal completion (ReturnType::Yield and now CompletionRecord::Return). This should be a different case with Yield statements being normal completions (CompletionRecord::Normal) and return statements being return completions (CompletionRecord::Return).

Completing the above change appears to require more evaluation/reevaluation of Generator executions and/or CompletionRecord semantics in the Vm as when the change was initially attempted, a number of test262 tests failed.

@nekevss nekevss added E-Medium Medium difficulty problem vm Issues and PRs related to the Boa Virtual Machine. labels Mar 16, 2023
@jedel1043 jedel1043 moved this to To do in Boa pre-v1 Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Medium Medium difficulty problem vm Issues and PRs related to the Boa Virtual Machine.
Projects
Status: To do
Development

No branches or pull requests

1 participant